Open
Conversation
Update Firebase AI Logic to 34.11.0
lethargicpanda
requested review from
JolandaVerhoef,
calren and
ksemenova
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase BOM version from 34.10.0 to 34.11.0 in the version catalog. Feedback indicates that this update constitutes a change to the underlying business logic, which necessitates corresponding updates to the README.md files of the affected samples to comply with the repository style guide.
| coilCompose = "3.1.0" | ||
| firebaseAiOndevice = "16.0.0-beta01" | ||
| firebaseBom = "34.10.0" | ||
| firebaseBom = "34.11.0" |
Contributor
There was a problem hiding this comment.
The update to the Firebase AI Logic version (BOM 34.11.0) constitutes a modification to the underlying business logic for the samples. According to the repository style guide (line 73), such changes should be reflected in the README.md files of the affected samples. These updates are currently missing from the pull request.
References
- When a view model or the business logic is modified in the code of a sample, verify that these changes are properly reflected in the README.md of this sample. (link)
ksemenova
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Firebase AI Logic to 34.11.0