Change the viewport-fit so env(safe-area-inset-bottom, 0) is evaluated by Safari properly.
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I reproduced this bug on iOS 17.4. In the Safari browser it worked fine, but after adding a shortcut to the home screen, Mobile Tab behaves differently. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is specific to the bottom safe area for IOS (and maybe if some android devices have these).
I deployed 2 different sites so they can be tested individually, only two extensions installed: Flarum PWA & Mobile Tab.
https://before-pwa-fix.pigeons.dev/
https://after-pwa-fix.pigeons.dev/
Before:
After:
It seems like
safe-area-inset-bottomisn't evaluated whenviewport-fitis not set tocover.As a side effect, this is the change that happens when viewing the device on landscape.
Before:
After:
Tested also with an android device which didn't have any changes on my end.