Combining duplicate schemas #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreytreyt
reviewed
Jan 18, 2025
| public bool IsCommonDocument { get; set; } = false; | ||
| public string CommonDocumentName { get; set; } = "YARP"; | ||
| public bool RenameDuplicateSchemas { get; set; } = false; | ||
| public string DuplicateSchemas { get; set; } = "First"; |
Owner
There was a problem hiding this comment.
@okAiSun Hi! Let's use enum like First, Rename, Combine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up with @waynebowie99 's changes, this gives the option to combine the properties of duplicate classes so they will still be one class. Mismatched properties are set to be nullable, since they may not exist on a get.
You can set how you'd like to handle the duplicate schemas in the app settings, with the default being "First", in which only the first class is added. (How the main branch works now)