Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

remove duplicate encoding in multipart upload #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dudif
Copy link

@dudif dudif commented Jul 20, 2017

remove encoding of s3 key when you try to upload in multipart because it cause duplicate encoding since aws also does encoding on the key.
you can also see that when you upload file not in multipart you never do encoding on the key

right now it causes an error if you try to sync file called "example 1.png" in multi part.
because it does encoding on the key to this "example%201.png" and the aws does encoding again i guess
and the key changed to "example%251.png" which not exist.

thanks

remove encoding of s3 key when you try to upload in multipart because it cause duplicate encoding since aws also does encoding on the key.
you can also see that when you upload file not in multipart you never do encoding on the key
@OmgImAlexis OmgImAlexis modified the milestone: Backlog Aug 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants