This repository has been archived by the owner on Feb 12, 2021. It is now read-only.
remove duplicate encoding in multipart upload #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove encoding of s3 key when you try to upload in multipart because it cause duplicate encoding since aws also does encoding on the key.
you can also see that when you upload file not in multipart you never do encoding on the key
right now it causes an error if you try to sync file called "example 1.png" in multi part.
because it does encoding on the key to this "example%201.png" and the aws does encoding again i guess
and the key changed to "example%251.png" which not exist.
thanks