WIP: add test for option in message descriptors #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[test] | ||
| fn serialize_options() { | ||
| let json = to_json( | ||
| Aggregate::default().descriptor().descriptor_proto() |
There was a problem hiding this comment.
descriptor_proto returns a prost_types::MessageDescriptor, which doesn't have support for extension fields/options, so unfortunately there's no way for this to work until tokio-rs/prost#1031 is implemented.
There was a problem hiding this comment.
I'm not sure why this is bound to the edition stuff. custom options have been available in protobuf much before edition has been introduced. the nearest issue I see is tokio-rs/prost#754
There was a problem hiding this comment.
you're right, that is not the issue I intended to link. tokio-rs/prost#674 tracks support for extension fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reproduction test for #124