AXI-MM Mem Ctrl Write response fix: fixed pop from empty std::queue representing fifo issue, causing the b valid to be forced high #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue comes from the bvalid signal being set if the output write queue is not empty and somewhere along the line an empty std::queue was popped, underflowing "_output_write_queue_occupancy" and making the mem controller think that there were memory responses to be sent, forcing bvalid high.
Below is a trace printout demonstrating the issue with the previous AXI-MM B resp signals coming from memory controller
Sent AW Trans id 0 @ Cycle 5!
black_box_0_inst: Sent W Transaction id: 0 @ Cycle 7!
[MEM CTRL] WRITE CALLBACK @ ch 0 @ addr [0] data_word: 0
[MEM CTRL] Sending back B Response! @ Cycle 1d!
[MEM CTRL] _output_write_queue_occupancy: 1
[MEM CTRL] Sending back B Response! @ Cycle 1e!
[MEM CTRL] _output_write_queue_occupancy: 1
[MEM CTRL] Sending back B Response! @ Cycle 21!
[MEM CTRL] _output_write_queue_occupancy: ffffffff
[MEM CTRL] Sending back B Response! @ Cycle 23!
[MEM CTRL] _output_write_queue_occupancy: fffffffe