Added NoC flit traffic trace support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueqri
commented
Nov 16, 2023
|
|
||
| protected: | ||
| int _delay; | ||
| T * _input; | ||
| T * _output; | ||
| queue<pair<int, T *> > _wait_queue; | ||
| deque<pair<int, T *> > _wait_queue; |
There was a problem hiding this comment.
We changed queue to deque in order to iterate the _wait_queue for tracing the on-the-fly flits, given that queue is not iterable. And there will be no performance effects resulting from this change, since deque is the underlying container used by the queue by default.
ueqri
commented
Nov 16, 2023
| int src_router_id = (src_router != nullptr) ? src_router->GetID() : -1; | ||
| int sink_router_id = (sink_router != nullptr) ? sink_router->GetID() : -1; | ||
| for (const auto & d : _wait_queue) { | ||
| os << sim_time << ", " << src_router_id << ", " << sink_router_id << ", " |
There was a problem hiding this comment.
It is a little tricky here. There may be a better solution for capturing the data inside the BookSim codebase.
andrewboutros
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flits on the fly (i.e., traversing router-to-router links) are traced for visualization and further analysis.
The MLP example at commit 285822f works fine, and the traced data looks as expected.
But more work is still needed in this PR to enable automation (e.g., the newly uploaded
rad-sim/sim/sanitize_flit_traces.pyshould be more general).