Fixed bug occurring when connection string specifies non-zero index and server requires authentication #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when selecting appropriate database
|
Any chance we can merge this @andrew-bn ? |
|
can we merge this in? the library is not very useful for me if we can't handle authenticated servers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to a server that requires authentication, the PrepareClientConnection method would throw an exception if the database index was greater than zero. Fixed by adding support for parsing password property from connection string and then using that property to authenticate when it is set. Also added IsAuthenticated flag, which is used to preserve authentication status when a pooled connection is re-used, avoiding a second call to AUTH.