Compile fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build issues on Fedora 41.
Conversion of
const vk::ArrayWrapper1D<char, 256>&tostd::stringis ambiguous. Convert the other side tostd::stringinstead.The result of
createComputePipelineUniqueneeds to be "unwrapped" manually. Implicit unwrapping is no longer supported.There was no rule to compile the shader. Someone experimenting with the shader source would need to compile it manually to see the result of the change.
The pre-compiled shader was in the source directory, but the
mandelbrotbinary would look in the binary directory. That would break when building outside the source tree. The shader is generated in the binary tree now.