Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra api calls to extend the go library #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pjmuller
Copy link
Contributor

@pjmuller pjmuller commented Jul 3, 2016

Some extra methods.

This is my first go code, I followed your lead. But if there are things that seem off.

Just let me know and I'll correct

@@ -36,3 +36,10 @@ func (client *Client) GetAppBySpaceIdAndSlug(spaceId int64, slug string) (app *A
err = client.Request("GET", path, nil, nil, &app)
return
}

// https://developers.podio.com/doc/applications/get-space-app-dependencies-45779
func (client *Client) GetSpaceDependencies(spaceId int64) (response *interface{}, err error) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should define the return type -- I'm not sure how this is supposed to work?

@andreas
Copy link
Owner

andreas commented Jul 4, 2016

A couple of comments, but otherwise looks good 😄

@pjmuller
Copy link
Contributor Author

pjmuller commented Jul 5, 2016

Ok clear comments and I think I know what to change. Will commit later this week probably

@pjmuller
Copy link
Contributor Author

Hi Andreas, got a bit (or even a lot of delay) on this one. Haven't forgotten however ;).

Will make the tiny changes in a couple of weeks normally (if all goes according to plan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants