Use latest optiopay/kafka + update compatability #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the health check not timing out under certain conditions and traced it to the optiopay/kafka client library. That issue has since been fixed in optiopay/kafka#68. I've updated the library to the latest version and also added all the new versions of Kafka into the compatibility spec. I had to remove pre 0.10 Kafka because it seems to not work with the new client library. I suspect this is because it was in the 0.10 that an API protocol was added: https://cwiki.apache.org/confluence/display/KAFKA/KIP-35+-+Retrieving+protocol+version
Upstream now supports go modules which seems to break govendor when using the v2 subdirectory (at least I can't make it work).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the health check not timing out under certain conditions and
traced it to the optiopay/kafka client library. That issue has since
been fixed in optiopay/kafka#68. I've updated
the library to the latest version and also added all the new versions of
Kafka into the compatibility spec. I had to remove pre 0.10 Kafka
because it seems to not work with the new client library. I suspect this
is because it was in the 0.10 that an API protocol was added:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-35+-+Retrieving+protocol+version