refactor: Refactor sync modifiers to use shared Data1D processing logic

[andeplane]

Summary

Fixes #186

Refactors all three sync modifiers to use the shared processData1D() helper function, reducing each file from ~125 lines to ~50-60 lines.

Changes

Refactored:

• src/modifiers/synccomputesmodifier.ts
• src/modifiers/syncfixesmodifier.ts
• src/modifiers/syncvariablesmodifier.ts

Each modifier now:

• Calls the appropriate sync method (syncComputes, syncFixes, or syncVariables)
• Gets the appropriate name array (getComputeNames, getFixNames, or getVariableNames)
• Loops through names to create/update modifier objects
• Calls the shared processData1D() function for Data1D processing
• Assigns to the appropriate output collection

Benefits

• Significant reduction in code duplication: Each file reduced by ~50%
• Easier to maintain and test: Changes to Data1D processing logic happen in one place
• Consistent behavior: All sync modifiers use the same processing logic
• Makes it easier to add new modifiers: Clear pattern to follow

Prerequisites

Requires #185 to be completed first (extraction of shared Data1D processing logic).

---

This pull request contains changes generated by a Cursor Cloud Agent

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[andeplane]

/gemini review

[gemini-code-assist]

Code Review

This pull request is a great refactoring that significantly reduces code duplication by extracting shared logic into a processData1D helper function. This improves maintainability and consistency across the sync modifiers. My review includes a few minor suggestions for the new helper function to enhance performance and readability.

[andeplane]

/gemini review

[gemini-code-assist]

Code Review

This is an excellent refactoring that significantly reduces code duplication by introducing the processData1D helper function. This greatly improves maintainability and consistency across the sync modifiers. The changes are clear and follow the stated goals in the pull request description. I have one minor suggestion to improve the readability of the data processing loop in the new helper function.

[gemini-code-assist]

The current logic for populating currentData1D.data is functionally correct, but it could be made more explicit to improve readability. By using an if/else block, you can clearly separate the logic for initializing a new row (for j === 0) from appending to an existing row (for j > 0). This makes the intent of the code easier to grasp at a glance.

Suggested change

	for (let k = lengthBeforeWeStart; k < xValues.length; k++) {
	if (j === 0) {
	currentData1D.data.push([xValues[k]]);
	}
	currentData1D.data[k].push(yValues[k]);
	}
	for (let k = lengthBeforeWeStart; k < xValues.length; k++) {
	if (j === 0) {
	currentData1D.data.push([xValues[k], yValues[k]]);
	} else {
	currentData1D.data[k].push(yValues[k]);
	}
	}