refactor: Extract common Data1D processing logic from sync modifiers

[andeplane]

Summary

Fixes #185

Extracts common Data1D processing logic from the three sync modifiers into a shared helper function, reducing code duplication by ~80%.

Changes

• Created shared processData1D() helper function in src/modifiers/modifier.ts
• Extracted common logic for:
  • Getting data1DNames wrapper and extracting size
  • Checking if data1D needs to be created
  • Processing clearPerSync logic
  • Looping through data1DVector and extracting x/y values from WASM memory
  • Proper cleanup of all WASM objects

Benefits

• Reduces code duplication: ~125 lines per file → ~50-60 lines per modifier
• Easier maintenance: Fix bugs/improvements in one place
• Consistent WASM memory cleanup: Ensures all modifiers handle cleanup the same way
• Easier to add new modifiers: Future Data1D processing modifiers can reuse the helper

Files Modified

• src/modifiers/modifier.ts (added helper function)

---

This pull request contains changes generated by a Cursor Cloud Agent

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[andeplane]

/gemini review

[gemini-code-assist]

Code Review

This pull request does a great job of refactoring the common Data1D processing logic into a shared processData1D helper function, significantly reducing code duplication. This is a valuable improvement for maintainability.

I've reviewed the changes and have a few suggestions to further improve the new helper function and its usage, focusing on performance, clarity, and modern TypeScript practices. My comments include a small optimization, removing a redundant check, and fixing a typo in a comment. I've also suggested using object destructuring to make the code in the sync modifiers more idiomatic when updating state from the helper function's result.

[andeplane]

/gemini review

[gemini-code-assist]

Code Review

This pull request does a great job of refactoring duplicated code into a shared processData1D helper function, which significantly improves maintainability. The logic extraction is well-executed. My review includes a few suggestions to further improve the new helper function's clarity and performance, and to make the calling code in the modifiers more concise.

[andeplane]

/gemini review

[gemini-code-assist]

Code Review

The pull request successfully extracts common Data1D processing logic into a shared helper function, significantly reducing code duplication and improving maintainability across SyncComputesModifier, SyncFixesModifier, and SyncVariablesModifier. The changes are well-structured and address the stated objective of reducing redundancy and ensuring consistent WASM memory cleanup. The introduction of the processData1D function is a good refactoring step.

[gemini-code-assist]

The xValues array is only used when j === 0. However, it is declared inside the loop, which means memory is allocated for it in each iteration, even when it's not used. This could lead to unnecessary memory allocations and potential performance overhead, especially if data1DNamesSize is large. Consider moving the declaration and assignment of xValues outside the loop, or only assign it when j === 0.

        const xValuesPointer = lmpData.getXValuesPointer() / 4;
        const xValues = input.wasm.HEAPF32.subarray(
          xValuesPointer,
          xValuesPointer + numPoints,
        );
        for (let k = lengthBeforeWeStart; k < numPoints; k++) {
          data1D.data.push([xValues[k]]);
          data1D.data[k].push(yValues[k]);
        }