Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#168430590 user can get an accommodation detail using its ID #67

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#168430590 user can get an accommodation detail using its ID #67

wants to merge 1 commit into from

Conversation

ladaposamuel
Copy link
Collaborator

What does this PR do?

This PR will enable a user to get an accommodation detail using its ID

Description of Task to be completed?

  • created route
  • created controller function
  • wrote tests to affirm feature

How should this be manually tested?

  • CLONE this repo
  • open the cloned directory
  • run npm install
  • run migration and seed commands
  • run npm run start:dev
  • access the route as /accommodation/{accommodationID}

What are the relevant pivotal tracker stories?

#168430590

@ladaposamuel ladaposamuel added the WIP Work in progress label Sep 13, 2019
@tejiri4 tejiri4 temporarily deployed to storm-backend-pr-67 September 13, 2019 09:52 Inactive
@tejiri4
Copy link
Contributor

tejiri4 commented Sep 13, 2019

You are also expected to work on getting all accommodation too. you can add it to your PT story description if it is not there.

@ladaposamuel
Copy link
Collaborator Author

You are also expected to work on getting all accommodation too. you can add it to your PT story description if it is not there.

Noted I will do so

@tejiri4
Copy link
Contributor

tejiri4 commented Sep 16, 2019

what is the status of this PR?

@ladaposamuel ladaposamuel force-pushed the ft-user-get-accomodation-168430590 branch from d6c2960 to 12e1daa Compare September 16, 2019 15:42
@ladaposamuel ladaposamuel temporarily deployed to storm-backend-pr-67 September 16, 2019 15:42 Inactive
@ladaposamuel
Copy link
Collaborator Author

what is the status of this PR?

I apologize for the delay, I got engaged in other tasks.

@ladaposamuel ladaposamuel force-pushed the ft-user-get-accomodation-168430590 branch from 12e1daa to 36663ec Compare September 16, 2019 17:46
@ladaposamuel ladaposamuel temporarily deployed to storm-backend-pr-67 September 16, 2019 17:47 Inactive
@codeclimate
Copy link

codeclimate bot commented Sep 16, 2019 •
edited
Loading

Code Climate has analyzed commit d57001f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 93.3% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.7% (0.0% change).

View more on Code Climate.

@ladaposamuel
feat(get-accommodation): user can get an accommodation detail
d57001f 
- created route
- created controller function 
- wrote tests to affirm feature
[Finishes #168430590]
@ladaposamuel ladaposamuel force-pushed the ft-user-get-accomodation-168430590 branch from 36663ec to d57001f Compare September 16, 2019 17:55
@ladaposamuel ladaposamuel requested review from jsbuddy, dinorhythms, komsic and tejiri4 and removed request for jsbuddy September 16, 2019 18:06
@ladaposamuel ladaposamuel added Finished completed task and removed WIP Work in progress labels Sep 16, 2019
@tejiri4
Copy link
Contributor

tejiri4 commented Sep 17, 2019 •
edited
Loading

The ratings and like should be included when getting an accommodation look at jude PR on how he fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinorhythms dinorhythms Awaiting requested review from dinorhythms

@jsbuddy jsbuddy Awaiting requested review from jsbuddy

@komsic komsic Awaiting requested review from komsic

@tejiri4 tejiri4 Awaiting requested review from tejiri4

Assignees
No one assigned
Labels
Finished completed task Heroku Verified Review me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladaposamuel @tejiri4