Feedback #2
Open
Feedback #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linter action have to run on every push and pull_request.
…red-black Revert "Red black"
Red black в dev
…rom any derived tree
* feat: Add AVL tree with own BST implementation
* Create LICENSE * fix: change insert method * fix: change tests * repo: add CI * feat: implement remove method and test for it
Co-authored-by: Nikita Lukonenko <[email protected]>
…starting the application
…e graphical interface
esvault
reviewed
May 2, 2023
| the tree is invalid red-black tree, and any other number is the black height | ||
| of the entire tree. | ||
| */ | ||
| private fun <K : Comparable<K>, V> isRbt(root: RBTNode<K, V>?): Int { |
There was a problem hiding this comment.
Данная функция должна возвращать Boolean значение.
|
|
||
| import bst.nodes.BSTNode | ||
|
|
||
| class BSTree<K : Comparable<K>, V>(val key: K? = null, val value: V? = null) : |
There was a problem hiding this comment.
Такое ощущение, что в конструкторе не нужны key и value. У пользователя есть функции вставки.
| import org.junit.jupiter.api.Nested | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class RbtTest { |
There was a problem hiding this comment.
Кажется еще нужны тесты для проверки корректности поворотов в различных кейсах вставок/удаления
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.