Info icon widget #2010
Open
Info icon widget #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IonutMuthi <[email protected]>
Signed-off-by: IonutMuthi <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds an info icon widget feature across several IIOWidgets to display helpful information when hovered. Key changes include:
- Introducing an info message parameter in the widget builder and recipe.
- Updating both editable and combo GUI strategies to integrate the new info icon.
- Adding a new InfoIconWidget implementation and its associated header.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| iio-widgets/src/iiowidgetbuilder.cpp | Added info message support in widget construction. |
| iio-widgets/src/guistrategy/editableguistrategy.cpp | Integrated the info icon into the editable widget layout. |
| iio-widgets/src/guistrategy/comboguistrategy.cpp | Integrated the info icon into the combo widget layout. |
| iio-widgets/include/iio-widgets/iiowidgetdata.h | Extended widget recipe with an info message field. |
| iio-widgets/include/iio-widgets/iiowidgetbuilder.h | Added declaration for the info message setter and member. |
| iio-widgets/include/guistrategy/* | Updated GUI strategy interfaces and headers to support the info icon. |
| gui/src/widgets/infoiconwidget.cpp & gui/include/gui/widgets/infoiconwidget.h | Added new implementation and header for InfoIconWidget. |
Files not reviewed (1)
- gui/res/resources.qrc: Language not supported
| titleLayout->addWidget(m_infoIcon); | ||
| titleLayout->addItem(new QSpacerItem(1, 1, QSizePolicy::Expanding, QSizePolicy::Preferred)); | ||
|
|
||
| m_ui->layout()->addItem(titleLayout); |
There was a problem hiding this comment.
Consider using 'addLayout(titleLayout)' instead of 'addItem(titleLayout)' when adding a QHBoxLayout to the parent layout to ensure proper layout behavior.
Suggested change
| m_ui->layout()->addItem(titleLayout); | |
| m_ui->layout()->addLayout(titleLayout); |
Copilot uses AI. Check for mistakes.
Signed-off-by: IonutMuthi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added info icon widget
Added info message option for IIOWidgets
Added info icon to combobox (compact) and editable IIOWidgets