Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adi: adf4371: add debugfs support #616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adi: adf4371: add debugfs support #616

wants to merge 1 commit into from

Conversation

amiclaus
Copy link
Contributor

@amiclaus amiclaus commented Nov 22, 2024

Description

Add support for direct register access within the adf4371 pyadi implementation.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • OS:

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Add support for direct register access within the adf4371 pyadi
implementation.

Signed-off-by: Antoniu Miclaus <[email protected]>
@amiclaus amiclaus self-assigned this Nov 22, 2024
Copy link

Generated documentation for this PR is available at Link

Copy link

Test Results

1 643 tests  ±0     376 ✅ ±0   11m 59s ⏱️ +5s
    1 suites ±0   1 267 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit fe9be81. ± Comparison against base commit a073555.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[14.0, 16.0, 30.5, 7.5, 22.0, 26.0, 8.0, 23.0, 6.5, 3.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[23.5, 1.0, 24.5, 17.0, 32.5, 2.0, 27.0, 10.5, 4.5, 30.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-3.8, -32.05, -5.9, -6.55, -22.95, -34.65, -25.55, -18.45, -34.15, -26.2]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-36.25, -27.55, -29.3, -34.05, -27.15, -17.9, -33.55, -1.3, -32.9, -2.0]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[10.0, 14.5, 12.5, 14.0, 20.0, 29.5, 27.0, 18.5, 21.0, 17.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[18.5, 15.0, 16.5, 24.0, 21.5, 3.0, 5.0, 14.0, 10.5, 20.5]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-8.55, -19.75, -6.65, -17.75, -13.35, -18.45, -29.6, -2.7, -30.05, -32.8]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-1.95, -32.15, -30.0, -20.75, -35.35, -31.65, -22.05, -7.8, -23.6, -10.3]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]

Copy link

Test Results

1 643 tests  ±0     376 ✅ ±0   11m 56s ⏱️ +2s
    1 suites ±0   1 267 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit fe9be81. ± Comparison against base commit a073555.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[14.0, 16.0, 30.5, 7.5, 22.0, 26.0, 8.0, 23.0, 6.5, 3.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[23.5, 1.0, 24.5, 17.0, 32.5, 2.0, 27.0, 10.5, 4.5, 30.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-3.8, -32.05, -5.9, -6.55, -22.95, -34.65, -25.55, -18.45, -34.15, -26.2]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-36.25, -27.55, -29.3, -34.05, -27.15, -17.9, -33.55, -1.3, -32.9, -2.0]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[2.5, 0.5, 15.0, 32.5, 18.0, 17.0, 7.0, 18.0, 17.5, 0.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[31.0, 8.0, 22.0, 3.0, 8.0, 19.0, 28.0, 15.0, 3.0, 30.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-28.95, -5.9, -20.75, -28.35, -2.15, -20.25, -34.6, -7.65, -19.0, -23.6]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-8.1, -18.0, -0.4, -37.8, -4.9, -37.15, -36.8, -32.35, -31.0, -2.7]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]

Copy link

github-actions bot commented Nov 22, 2024

Test Results

1 643 tests  ±0     376 ✅ ±0   11m 58s ⏱️ +4s
    1 suites ±0   1 267 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit fe9be81. ± Comparison against base commit a073555.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[14.0, 16.0, 30.5, 7.5, 22.0, 26.0, 8.0, 23.0, 6.5, 3.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[23.5, 1.0, 24.5, 17.0, 32.5, 2.0, 27.0, 10.5, 4.5, 30.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-3.8, -32.05, -5.9, -6.55, -22.95, -34.65, -25.55, -18.45, -34.15, -26.2]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-36.25, -27.55, -29.3, -34.05, -27.15, -17.9, -33.55, -1.3, -32.9, -2.0]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[28.5, 11.0, 15.0, 25.5, 15.5, 33.0, 20.0, 13.0, 2.0, 32.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[33.5, 6.0, 26.5, 10.5, 31.5, 24.0, 29.5, 22.0, 9.5, 31.5]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-14.4, -32.35, -3.4, -35.0, -21.8, -7.9, -9.95, -19.1, -22.2, -19.35]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-12.05, -22.6, -21.95, -37.7, -5.45, -31.25, -6.55, -1.45, -16.05, -34.15]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant