This repository was archived by the owner on Apr 30, 2021. It is now read-only.
Use PyYAML >= 5.1 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a "magic" tag class for PyYAML by extending yaml.YAMLObject is equivalent to registering the methods manually with yaml.add_representer and yaml.add_constructor - only one approach is needed.
With PyYAML 5.1, `yaml.load` was deprecated, see https://msg.pyyaml.org/load To guard against potential future vulnerabilities, use SafeLoader in this package.
The code was changed to be compatible with the new version.
|
Thank you @mzagozen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People are getting CVE hits on using an old PyYAML version. While it is possible to change usage of pyyaml to use
yaml.safe_loadeven with the old version, that won't make the warning go away. It's best to just upgrade to latest. I had this branch with PyYAML 5.x compatibility fixes ready to go, but was waiting on PyYAML 5.2 to be released. It has been 6 months now. I don't think it's happening any time soon.Anyway, the current 5.1 version has a bug where you must explicitly register the loader for every custom directive parsing class. This was supposed to be a global setting - like you specifiy you only want to use
SafeLoader, but it doesn't work. Even with the explicit workaround, IMHO this is an improvement on the old version as it includes more documentation :)@an2deg I set your
rel-0.1.8branch as the base here, as that is the current public release.Closes #39