Updated bad color from darkred to yellow #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am red-green colorblind which affects 6% of the male population. Having one chart that uses both darkred and darkgreen is incredibly difficult for me to read. I didn't even notice that there were different colors until I saw the source code. What I inevitably did was change one of the colors to something much brighter. I would also be okay with changing any of the dark colors to a bright color. Dark colors are hard to distinguish from each other in general, and when they are both red and green, then it is especially difficult.
|
sorry about that and thanks for the fix. It would be great if you could provide a screenshot of your changed version. |
|
(I'm a bit concerned on how clear yellow is on the screen. really we should have made sure everything works for the various color-blindnesses, in particular the common ones - we do that for the sklearn docs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am red-green colorblind which affects 6% of the male population. Having one chart that uses both darkred and darkgreen is incredibly difficult for me to read. I didn't even notice that there were different colors until I saw the source code. What I inevitably did was change one of the colors to something much brighter. I would also be okay with changing any of the dark colors to a bright color. Dark colors are hard to distinguish from each other in general, and when they are both red and green, then it is especially difficult.