Skip to content

Commit

Permalink
fix(markers-display): src without marker
Browse files Browse the repository at this point in the history
When loading a source that did not contain a marker, the `loadMarkers` function threw an error because it was trying to add a component that did not exist.

- rename child component name
- deletes `browser.js` which is no longer required
- update `package` verion
  • Loading branch information
amtins committed Dec 3, 2023
1 parent 667b61b commit 992c505
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cassettator.js",
"version": "0.69.420",
"version": "0.69.42035",
"description": "A collection of video.js components and plugins",
"author": "amtins <[email protected]>",
"license": "MIT",
Expand Down
7 changes: 0 additions & 7 deletions src/browser.js

This file was deleted.

3 changes: 2 additions & 1 deletion src/markers/src/markers-display.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ class MarkersDisplay extends videojs.getComponent('component') {
);

if (!markersTrack) {
this.addChild('marker', {
this.addChild('marker-empty', {
className: 'marker-empty',
componentClass: 'markerDisplay',
startTime: 0,
endTime: this.player().duration(),
});
Expand Down

0 comments on commit 992c505

Please sign in to comment.