Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Bento amp-copy #35221

Closed
wants to merge 19 commits into from
Closed

✨ Bento amp-copy #35221

wants to merge 19 commits into from

Commits on Jul 14, 2021

  1. Initial commit for amp-copy bento component

    @mangesh
    mangesh committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    a19ce38 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ampproject:main' into bento/amp-copy

    @AnuragVasanwala
    AnuragVasanwala authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    66c6e3c View commit details
    Browse the repository at this point in the history

  3. ♻️ Updated and prettify storybook

    @AnuragVasanwala
    AnuragVasanwala committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    f988e38 View commit details
    Browse the repository at this point in the history

  4. Remove debug statements

    @mangesh
    mangesh committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    8678710 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Remove CSS

    @mangesh
    mangesh committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    4477492 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Add new line

    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    f52830f View commit details
    Browse the repository at this point in the history

  2. Remove unwanted code line

    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    5476eec View commit details
    Browse the repository at this point in the history

  3. Optimise the code 

    Remove unwanted if and else condition
    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    58461e8 View commit details
    Browse the repository at this point in the history

  4. Address the feedback 

    Fix some typos
Optimise the code
    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    7582105 View commit details
    Browse the repository at this point in the history

  5. Remove validator files 

    It is not valid AMP until the feature is ready for wider use.
Files can be added back later when the AMP is ready
    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    53d124e View commit details
    Browse the repository at this point in the history

  6. Store isCopySupported in state based on the document value 

    Also, prettify the code
    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6df6823 View commit details
    Browse the repository at this point in the history

  7. Add missing dependencies

    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    3eef1d2 View commit details
    Browse the repository at this point in the history

  8. Prefer ref.current.ownerDocument to document

    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    1f15039 View commit details
    Browse the repository at this point in the history

  9. Add support for copying static text 

    Text passed in text attribute will get copied,
if sorceId attribute is missing
    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    553b257 View commit details
    Browse the repository at this point in the history

  10. Add rendering support for the subsequent successful copies

    @mangesh
    mangesh committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    b36e342 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Merge branch 'ampproject:main' into bento/amp-copy

    @AnuragVasanwala
    AnuragVasanwala authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    4d03ab8 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Register API action for copy function

    @mangesh
    mangesh committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    96d2637 View commit details
    Browse the repository at this point in the history

  2. ♻️ ✨ Added Action API copyToClipboard

    @AnuragVasanwala
    AnuragVasanwala committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    e42c1b2 View commit details
    Browse the repository at this point in the history

  3. 🐛 Minor Fixes for API Action

    @AnuragVasanwala
    AnuragVasanwala committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    f083298 View commit details
    Browse the repository at this point in the history