Skip to content

Commit

Permalink
🏗 Update CircleCI Orbs versions (#38811)
Browse files Browse the repository at this point in the history
* Update CircleCI Orbs versions

* Explicitly set `ORB_PARAM_CHROME_VERSION` env variable in shell script
(workaround for CircleCI-Public/browser-tools-orb#70)
  • Loading branch information
danielrozenberg committed Apr 25, 2023
1 parent 08837e1 commit f962c0d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
version: 2.1

orbs:
browser-tools: circleci/browser-tools@1.2.3
codecov: codecov/[email protected].3
node: circleci/node@5.0.3
browser-tools: circleci/browser-tools@1.4.1
codecov: codecov/[email protected].4
node: circleci/node@5.1.0

push_and_pr_builds: &push_and_pr_builds
filters:
Expand Down Expand Up @@ -133,7 +133,7 @@ commands:
name: 'Get Pinned Chrome Version'
command: ./.circleci/get_pinned_chrome_version.sh
- browser-tools/install-chrome:
chrome-version: ${CHROME_VERSION}
# chrome-version is set in ./.circleci/get_pinned_chrome_version.sh, see files for details.
replace-existing: true
- browser-tools/install-chromedriver
install_firefox:
Expand Down
3 changes: 2 additions & 1 deletion .circleci/get_pinned_chrome_version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,6 @@ echo "$(GREEN "Determining Chrome version...")"
CHROME_VERSION="$(curl -sS --retry 3 ${CHROME_VERSION_HISTORY_URL} | jq -r ".versions[]|.version" | grep -m 1 "${CHROME_MAJOR_VERSION}\.[[:digit:]]\+.[[:digit:]]\+.[[:digit:]]\+")"
echo "$(GREEN "Chrome version is") $(CYAN "${CHROME_VERSION}")"

echo "export CHROME_VERSION=$CHROME_VERSION" >> $BASH_ENV
# Workaround for https://github.com/CircleCI-Public/browser-tools-orb/issues/70
echo "export ORB_PARAM_CHROME_VERSION=$CHROME_VERSION" >> $BASH_ENV
echo $(GREEN "Successfully determined pinned version of Chrome")

0 comments on commit f962c0d

Please sign in to comment.