Fix transaction release race#73
Open
simPod wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a transaction release race in
PostgresHandleConnection.The first commit adds a regression test that opens a transaction, commits it, and immediately opens another transaction. Before the fix, the previous transaction's close callback releases the connection lock asynchronously, so the second
beginTransaction()can observe the connection as still busy.Observed before the fix with assertions enabled:
Observed before the fix with assertions disabled, matching the production symptom:
The second commit makes
beginTransaction()wait for any pending transaction release before reserving the connection again, matching the behavior already used by query, execute, prepare, notify, and listen.