Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of libuv queue work API #83

Open
ghost opened this issue Mar 8, 2020 · 1 comment
Open

Removal of libuv queue work API #83

ghost opened this issue Mar 8, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 8, 2020 •
edited by ghost
Loading

I'd like to suggest that php-uv removes the support for libuv's queue work API. Even though it seems safe to the user from the outside, the API is expensive, limited and dangerous.

I'm sure with one or the other work it will segfault (we can already see that in #46). Instead of having such a potential dangerous API exposed, I'd like to see it instead removed and link to parallel, which is safe, offers a good range of features and is the dedicated PHP extension for parallelism.

What is the opinion of the maintainer on this matter?
@ghost
Copy link
Author

ghost commented May 27, 2020

@bwoebi thoughts?

@TheTechsTech TheTechsTech mentioned this issue Mar 16, 2023
Open
TheTechsTech added a commit to symplely/ext-uv that referenced this issue Apr 4, 2023
@TheTechsTech
new version ready, uv_queue_work works on PHP 8+
5f32796 
- Linux tests pass as is, Windows after callback not executed and segfaults still.

In reference to issues: amphp#83, amphp#93, amphp#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants