Fix tests on Windows

amphp · Apr 13, 2024 · 7ab614c · 7ab614c
1 parent a453d66
commit 7ab614c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/test/ResourceOutputStreamTest.php b/test/ResourceOutputStreamTest.php
@@ -5,6 +5,7 @@
 use Amp\ByteStream\ResourceOutputStream;
 use Amp\ByteStream\StreamException;
 use Amp\PHPUnit\AsyncTestCase;
+use const PHP_OS;
 
 class ResourceOutputStreamTest extends AsyncTestCase
 {
@@ -47,9 +48,14 @@ public function testBrokenPipe(): ?\Generator
         \fclose($b);
 
         $this->expectException(StreamException::class);
-        $this->expectExceptionMessage(/* S|s */ "end of 6 bytes failed with errno=32 Broken pipe");
+        $this->expectExceptionMessage(/* S|s */ "end of 6 bytes failed with errno=" . (\stripos(PHP_OS, "win") === 0 ? "10053" : "32 Broken pipe"));
 
         yield $stream->write("foobar");
+
+        // The first write still succeeds somehow on Windows...
+        if (\stripos(PHP_OS, "win") === 0) {
+            yield $stream->write("foobar");
+        }
     }
 
     public function testClosedRemoteSocket(): ?\Generator

diff --git a/test/ResourceStreamTest.php b/test/ResourceStreamTest.php
@@ -10,6 +10,7 @@
 use Amp\Delayed;
 use Amp\PHPUnit\AsyncTestCase;
 use Amp\Success;
+use const PHP_OS;
 
 class ResourceStreamTest extends AsyncTestCase
 {
@@ -77,6 +78,11 @@ public function testThrowsOnExternallyShutdownStreamWithLargePayload()
         $b->close();
 
         yield $writePromise;
+
+        // Windows apparently always needs another write...
+        if (\stripos(PHP_OS, "win") === 0) {
+            yield $a->write("foobar");
+        }
     }
 
     public function testThrowsOnExternallyShutdownStreamWithSmallPayloads()