Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-strings #686

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Use f-strings #686

merged 2 commits into from
Jul 12, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Jun 29, 2023

Replace % and .format syntax with f-strings where appropriate. Also replace the text indentation code with stdlib's textwrap.indent method call.

amoffatgmi
amoffatgmi previously approved these changes Jun 29, 2023
Copy link
Collaborator

@amoffatgmi amoffatgmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, lgtm

@amoffat
Copy link
Owner

amoffat commented Jun 29, 2023

Please don't force push @eumiro. It hides your changes and means I need to review them from the start again. Only add new commits so that the audit trail of what changed is clear.

@amoffatgmi amoffatgmi dismissed their stale review June 29, 2023 19:43

Force push invalidated changes

@eumiro
Copy link
Contributor Author

eumiro commented Jun 29, 2023

Sorry for the forcepush. I had difficulties running tests on my host, so I waited for the CI (that you had to approve). The only change I did now was the black reformat of one line.

In the first CI run I also saw one test fail and wanted to check it after the re-run of CI.

@eumiro eumiro requested a review from amoffatgmi June 30, 2023 18:37
@ecederstrand
Copy link
Collaborator

@eumiro There's a single test failure in test_change_log_message. Can you have a look at that?

@ecederstrand ecederstrand merged commit 4941fe0 into amoffat:develop Jul 12, 2023
19 checks passed
@ecederstrand
Copy link
Collaborator

Thanks for the contribution!

@eumiro eumiro deleted the fstrings branch July 12, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants