Skip to content

Commit

Permalink
cleanup includes
Browse files Browse the repository at this point in the history
  • Loading branch information
@amoffat
amoffat committed Aug 7, 2023
1 parent 0365c28 commit 89333ae
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions pyproject.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,9 @@ classifiers = [
"Topic :: Software Development :: Libraries :: Python Modules",
]
include = [
{ path = "CHANGELOG.md", format = "sdist" },
{ path = "MIGRATION.md", format = "sdist" },
{ path = "images", format = "sdist" },
{ path = "Makefile", format = "sdist" },
{ path = "tests", format = "sdist" },
{ path = "tox.ini", format = "sdist" },
"CHANGELOG.md",
"MIGRATION.md",
"LICENSE.txt",
]

[tool.poetry.dependencies]
Expand Down

5 comments on commit 89333ae

@mgorny
Copy link
Contributor

@mgorny mgorny commented on 89333ae Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? This only makes sdist useless to distributions (who need tests) but also installs documentation files straight into /usr/lib/python*/site-packages/ which is plain wrong.

@amoffat
Copy link
Owner Author

@amoffat amoffat commented on 89333ae Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgorny What is your recommendation on how it should be? I haven't had any feedback in this area

@mgorny
Copy link
Contributor

@mgorny mgorny commented on 89333ae Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version was fine. In fact, it was me who submitted it (245bdcd).

@amoffat
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgorny Got it, I will revert. Thanks for bringing it to my attention.

@mgorny
Copy link
Contributor

@mgorny mgorny commented on 89333ae Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please sign in to comment.