Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aetheria Slot display #210

Closed
wants to merge 2 commits into from
Closed

Fix Aetheria Slot display #210

wants to merge 2 commits into from

Conversation

jkisor
Copy link
Contributor

@jkisor jkisor commented Oct 18, 2021

Issue: #201

The Aetheria slots property is currently showing the bitmask as an integer (0,1,3,7).

Changes:

  • Define mapping to correct count.
  • Lookup count on the Character page (other pane)
  • Lookup count on the Account page

Screenshots (tested using property 322 value of 7)

treestats_aetheria_character

treestats_aetheria_account

Comment on lines +89 to +94
AETHERIA_SLOTS = {
0 => 0,
1 => 1,
3 => 2,
7 => 3
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we could use binary literals to be more explicit about what the keys are.

Suggested change
AETHERIA_SLOTS = {
0 => 0,
1 => 1,
3 => 2,
7 => 3
}
AETHERIA_SLOTS = {
0b000 => 0,
0b001 => 1,
0b011 => 2,
0b111 => 3
}

@jkisor jkisor changed the title Aetheria Fix Aetheria Slot display Oct 18, 2021
@amoeba
Copy link
Owner

amoeba commented Oct 23, 2021

This looks perfect, thanks @jkisor for another thorough PR. Your work is now on the main branch as:

and live on TreeStats.net.

@amoeba amoeba closed this Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants