Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Open Trickler w/ Python #51

Merged
merged 160 commits into from
Aug 15, 2021
Merged

Conversation

erichiggins
Copy link
Contributor

@erichiggins erichiggins commented Feb 5, 2021

The primary goals of this PR are to improve stability, maintainability, and code readability.

Here a few, more detailed, reasons:

  • A classic infinite loop w/ synchronous calls is more simple than event-based, asynchronous code
  • Python is easier for beginners and non-programmers than NodeJS
  • The NodeJS binary installed through Buildroot creates significant startup latency (up to 30 seconds)
  • Bluetooth libraries for Python have matured since the first Open Trickler was created, removing an obstacle

Other functional changes in this PR:

Open issues:

  • Verify full compatibility w/ existing mobile apps
  • Create alternate bluetooth module for future mobile app rewrite (e.g. don't use zero 0 values where they can be confused with null values)
  • Control Pi's onboard LED to indicate trickler status. Also support alternate/external status lights, as mentioned in Start Up Log/Status Indicator #30
  • Create web UI (see opentrickler_api.yaml)
  • Add support documentation to the webpage hosted on the Pi. Include details like the IP address, wiring guide, what the lights mean, debug tips, FAQ, and how to get more help.

…ch on memcache calls. Add timer delay in loop.
…c_update, conflicts with exisiting function from parent class.
…cs/projects into feature/python-trickler-rewrite
@erichiggins erichiggins marked this pull request as ready for review August 15, 2021 04:46
Copy link
Contributor Author

@erichiggins erichiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SD images seem to work as expected. Merging for now to prioritize one language and major version over two. Any other bugs can be fixed as needed.

@erichiggins erichiggins merged commit ded4b51 into develop Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant