This repository was archived by the owner on Oct 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Fixes #12: Add ability to output markdown #17
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will need to be update to display primary, secondary and index links in generated Markdown after this issue is fixed #19. |
I will rebase this during this week |
e14d0fe
to
ca38c56
Compare
This comment has been minimized.
This comment has been minimized.
I've resolved merge conflicts with Work in this PR is complete and ready to be reviewed. |
Closing in favour of #25 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Try it out with a new option
--syntax
:We still need to rename the repo after this PR is merged.
I've fixed this issue by simply declaring a second set of templates specifically for Markdown.
While working on it, I've considered few other options:
turndown
,showdown
) and none of them properly handled our html structure (tables, navigation block, etc.).Choosing either of these options would have added unnecessary complexity to the code (to make out layout with those libs) and increased number of bugs in the future. On the other hand, I think keeping templates up to date is straightforward and add no code complexity.