Skip to content

Conversation

@tomsfernandez
Copy link
Contributor

@tomsfernandez tomsfernandez commented Dec 28, 2021

Objective: have a way to unit-test the adapter logic inside the ResourceLoader implementations from a "shared" scala test suite.

  • This is also helpful to mock the "FileSystem" object and "spy" on the end products of AMF's uri-resolution mechanism. This is especially useful when debugging APIKIT Api Sync error cases.

Concerns

  • The only concern I have is regarding performance between the JvmFileSystem implementations and the legacy file reading mechanism. Unfortunately I don't see a way to easily benchmark this as disk I/O will affect the measurement a lot.

Note: this small refactor is made to be fully backwards compatible with the previous implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants