-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest API to add downloads #331
Merged
amir1376
merged 10 commits into
amir1376:master
from
talha5389:feat/rest-api-add-download
Jan 5, 2025
Merged
Rest API to add downloads #331
amir1376
merged 10 commits into
amir1376:master
from
talha5389:feat/rest-api-add-download
Jan 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat/rest-api-add-download
amir1376
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thank you for your effort on this PR! I've added some comments to a few sections that I think they could be improved
integration/server/src/main/kotlin/com/abdownloadmanager/integration/QueueModel.kt
Outdated
Show resolved
Hide resolved
integration/server/src/main/kotlin/com/abdownloadmanager/integration/Integration.kt
Outdated
Show resolved
Hide resolved
@amir1376 I have made requested changes. |
amir1376
approved these changes
Jan 5, 2025
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple support for adding download via http api
Difference between this and original
POST /add
used by browser extension is that it won't open open dialog to select queue and other settings allowing to add downloads in bulk without any user interaction.Of course, you still have to disable completion dialog in settings so they don't open for each download that gets completed