Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA tickets:
What exactly does this PR do?
.env.test
for running the tests instead of using the same.env
used for development purposes. In addition, a directoryhl7-uploads-test
is created to temporary stores the500HL7Messages.txt
produced by the tests.500HL7Messages.txt
created after running theyarn test
. This allows you to run the tests over and over again. Before, you had to manually delete500HL7Messages.txt
in order to pass all tests. If you ran the tests with500HL7Messages.txt
still indata/hl7-uploads
, some tests would fail.Do ANY of these changes introduce a breaking change? (in-scope or otherwise)
Manual test cases?
Case 1
yarn test
config.js: Using .env.test
.env.test
env file and not the.env
for developmentAfter running
yarn test
, ensure that you have the following directory:data/hl7-uploads-test/
and that it's empty, meaning it doesn't have the file500HL7Messages.txt
in it.yarn test
more than once without failing any tests. This is something we couldn't do before this PR.Case 2
yarn start
config.js: Using .env