This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Few improvements #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes more sense because: * No need in adding it into kernel's .gitignore * It will not be mistaken with kernel's source files
amezin
suggested changes
Oct 30, 2020
| cmd_parser.add_argument( | ||
| '-o', '--output', | ||
| type=str, default=default_output, | ||
| help="Path to resulting JSON file, default: %s" % (default_output, )) |
There was a problem hiding this comment.
Please use ArgumentDefaultsHelpFormatter instead of formatting help strings by hand. It's available even in Python 2. You won't need default_* variables with it.
|
Merged some of your changes by cherry-picking I'm still not sure about moving
I'm ok with adding |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.