improvements to speech to speech#264
Merged
Merged
Conversation
Collaborator
ldokovic-personal
left a comment
There was a problem hiding this comment.
The difference compared to the PR created `254 which addresses creating a global MODEL_PATH as an env variable is that here we are pulling it out of use across all platforms and OS's. It seems cleaner and more intuitive from a User point of view. In this way, we are making it clear that we will not deal with paths to the user directory in further steps.
Overall Lgtm
ldokovic-personal
approved these changes
May 14, 2026
Collaborator
Author
|
@sreeram-11 please consider this PR when thinking of tests for speech-speech playbook. Major possible testing changes are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ldokovic-personal @nikitaandrade-amd
Took feedback from Lazar and myself and modified this playbook. Key changes: