Skip to content

improvements to speech to speech#264

Merged
adamlam2-amd merged 4 commits into
mainfrom
adam/speech_speech
May 14, 2026
Merged

improvements to speech to speech#264
adamlam2-amd merged 4 commits into
mainfrom
adam/speech_speech

Conversation

@adamlam2-amd
Copy link
Copy Markdown
Collaborator

@ldokovic-personal @nikitaandrade-amd

Took feedback from Lazar and myself and modified this playbook. Key changes:

  • configured model installed to occur automatically and be managed by HuggingFace so users don't have to do it themselves
  • bug fixes in terms of dtype vs torch_dtype so that the code can run without error
  • Flow changes; we have the user download all the files first, and then explain each function after that if they wish
  • Took out the -share version of gradio as it has complicated unnecessary step (added it to next steps)
  • general formatting

Comment thread playbooks/dependencies/pytorch.md
Copy link
Copy Markdown
Collaborator

@ldokovic-personal ldokovic-personal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference compared to the PR created `254 which addresses creating a global MODEL_PATH as an env variable is that here we are pulling it out of use across all platforms and OS's. It seems cleaner and more intuitive from a User point of view. In this way, we are making it clear that we will not deal with paths to the user directory in further steps.

Overall Lgtm

@ldokovic-personal ldokovic-personal self-requested a review May 14, 2026 14:25
@adamlam2-amd adamlam2-amd merged commit be37208 into main May 14, 2026
7 checks passed
@adamlam2-amd
Copy link
Copy Markdown
Collaborator Author

@sreeram-11 please consider this PR when thinking of tests for speech-speech playbook. Major possible testing changes are:

  • downloading the model using Huggingface and its storage artifacts
  • took out the gradio_share part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants