Skip to content

niccli role: use defaults, don't set in play #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

niccli role: use defaults, don't set in play #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e24bea
niccli: don't force vars at role level, use defs
joshlay2amd Jan 27, 2025
84e908a
niccli: bump default
joshlay2amd Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packer-rocm/playbooks/niccli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
---
# yamllint disable rule:line-length
# vim: ft=yaml.ansible
- name: "Prepare 'niccli' and driver"
hosts: default
environment: # may be superfluous for your environment; mapped through Packer HCL with 'ansible_env_vars'
http_proxy: "{{ lookup('ansible.builtin.env', 'http_proxy') | default(omit) }}"
https_proxy: "{{ lookup('ansible.builtin.env', 'https_proxy') | default(omit) }}"
no_proxy: "{{ lookup('ansible.builtin.env', 'no_proxy') | default(omit) }}"
roles:
- name: Include 'niccli' Role
role: niccli
niccli_url: 'https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/Thor2/GCA2/bcm5760x_231.2.63.0a.zip'
niccli_sum: 'sha256:5c46de9addf9284fb48fef1c505c470c85fd4c129045bdd8ee706447bc1bd025'

# vim: ft=yaml.ansible
- { role: niccli }
2 changes: 1 addition & 1 deletion packer-rocm/playbooks/roles/niccli/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# - 'NetXtreme-E Linux Driver'
#
# NOTE/Warning: Patterns in URLs have not been consistent enough for templating to make [much] sense. Directories change along with releases.
niccli_url: 'https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/Thor2/GCA2/bcm5760x_231.2.63.0a.zip'
niccli_url: 'https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/BRCM_232.1.132.8/bcm_232.1.132.8c.tar.gz'

# 'niccli_sum' deliberately is *not* defaulted with the URL.
# if users want to change the link... they should not be required to correct or empty the checksum. this should act as opt-in validation, not a requirement.
Expand Down
Loading