Skip to content

add: safeguard circumvention option #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add: safeguard circumvention option #1686

wants to merge 1 commit into from

Conversation

DrTheodor
Copy link
Member

About the PR

Added a server config option to disable some safeguards.

Why / Balance

In some cases, java is being told that there's only 1 available CPU core, which may not be the case. But async locator util has a safeguard in place to ensure that there is AT LEAST 2 cpu cores (to offload the threads to), otherwise it fails.

Technical details

Requirements

Breaking changes

None

@DrTheodor DrTheodor requested review from a team as code owners June 30, 2025 09:24
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Tardis Components Area: Tardis components & manager. size/XS Denotes a PR that changes 0-9 lines. S: Needs Review Status: Requires additional reviews before being fully accepted. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jun 30, 2025
@GSMPBot GSMPBot requested review from Loqor, MaketendoDev and duzos June 30, 2025 09:25
@DrTheodor DrTheodor added A: Core Tech Area: Underlying core tech for the mod and the Github repository. T: Bugfix Type: Bugs and/or bugfixes. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on. and removed A: Tardis Components Area: Tardis components & manager. labels Jun 30, 2025
@github-actions github-actions bot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duzos duzos duzos approved these changes

@Loqor Loqor Awaiting requested review from Loqor

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the mod and the Github repository. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrTheodor @duzos