Simple ARS System #1627
Simple ARS System #1627
Conversation
github-actions
bot
added
A: Tardis Components
| } | ||
|
|
||
| // return the size of the template in blocks * 10 as the fuel cost | ||
| StructureTemplate template = optional.get(); |
There was a problem hiding this comment.
this fuel cost stuff should be provided by the BasicArsStructure
There was a problem hiding this comment.
or basically just any implementation
| return (int) Math.min(volume, FuelHandler.TARDIS_MAX_FUEL); | ||
| } | ||
|
|
||
| default Optional<Identifier> structureIdOptional() { |
There was a problem hiding this comment.
that doesnt make any sense
optionals exist to force people to handle nulls
whats the point of using an optional when you can just get a nullable id
There was a problem hiding this comment.
just
do it in the codec then
you dont have to introduce a whole new method that is used in a codec of another class
There was a problem hiding this comment.
either remove this method or remove the method which can return a nullable value
| return this.text().getString(); | ||
| } | ||
|
|
||
| private static Text createNameText(Identifier id, String prefix) { |
There was a problem hiding this comment.
why not use #toTranslationKey?
is it to handle the / (i dont rememer if they are handled by mc or not)?
if so, this method should be at TextUtils.
| } | ||
|
|
||
| static { | ||
| ServerPlayNetworking.registerGlobalReceiver(REQUEST_PLACE, (server, player, handler, buf, responseSender) -> { |
There was a problem hiding this comment.
ideally this piece of code should be in the handler
| Identifier id = this.id(); | ||
|
|
||
| return new Identifier(id.getNamespace(), "interiors/" + id.getPath()); | ||
| } | ||
|
|
||
| @Override | ||
| public Identifier structureId() { |
There was a problem hiding this comment.
???????????????????????????????????????????????
why does it just go to #getStructureLocation?
| import java.io.InputStreamReader; | ||
| import java.util.concurrent.atomic.AtomicReference; | ||
|
|
||
| public class JsonDecoder { |
github-actions
bot
added
the
S: Awaiting Changes
|
"heh let's do node based blah blah" 🤓👆 |
|
perish |
Mansarde
added
the
S: Draft
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
TODO /
About the PR
Why / Balance
Technical details
Media
Requirements
Breaking changes
Changelog