Skip to content

[NEEDS TESTING] fix: load the chunk before falling #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[NEEDS TESTING] fix: load the chunk before falling #1309

wants to merge 6 commits into from

Conversation

DrTheodor
Copy link
Member

About the PR

This is a follow up to my previous PR that fixes the chunk not being loaded on falling.

Requirements

@DrTheodor DrTheodor requested a review from a team as a code owner March 25, 2025 04:16
@github-actions github-actions bot added A: Tardis Components Area: Tardis components & manager. size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. labels Mar 25, 2025
@GSMPBot GSMPBot requested review from Loqor, MaketendoDev and duzos March 25, 2025 04:16
@DrTheodor DrTheodor changed the title fix: load the chunk before falling [NEEDS TESTING] fix: load the chunk before falling Mar 25, 2025
@DrTheodor DrTheodor added the S: Needs Testing Status: Requires testing. label Mar 25, 2025
@github-actions github-actions bot added S: Awaiting Changes Status: Changes are required before another review can happen. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. labels Mar 25, 2025
@DrTheodor DrTheodor requested a review from duzos March 25, 2025 12:01
@DrTheodor DrTheodor removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Mar 25, 2025
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted. and removed S: Awaiting Changes Status: Changes are required before another review can happen. labels Mar 25, 2025
@DrTheodor DrTheodor added S: Awaiting Changes Status: Changes are required before another review can happen. A: Core Tech Area: Underlying core tech for the mod and the Github repository. S: Needs Review Status: Requires additional reviews before being fully accepted. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. S: Awaiting Changes Status: Changes are required before another review can happen. labels Mar 25, 2025
@DrTheodor DrTheodor added this to the 1.2.0 PATCHES milestone Mar 25, 2025
@DrTheodor DrTheodor force-pushed the falling-chunk-loading branch from 43e9a57 to 20b094a Compare March 26, 2025 05:03
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Mar 26, 2025
@github-actions github-actions bot added the A: Console Area: Tardis console. label Mar 26, 2025
@github-actions github-actions bot added A: Engine Area: Tardis engine. A: Admin Tooling Area: Admin tooling and moderation. labels Mar 26, 2025
@DrTheodor DrTheodor force-pushed the falling-chunk-loading branch from d7dae27 to 5ed7aac Compare March 26, 2025 05:41
@DrTheodor DrTheodor added the S: Help Wanted Status: Requesting additional help for this to be completed. label Mar 26, 2025
@duzos duzos force-pushed the main branch 3 times, most recently from f9eed81 to 8564574 Compare March 29, 2025 21:23
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Apr 23, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Mansarde
Copy link
Collaborator

Mansarde commented May 2, 2025

I did some testing (with negative results unfortunately):

  • Started a new map with a fresh TARDIS
  • Took off with the TARDIS to a new chunk, land types disabled, Y high in the air, manual flight, max speed (with sonic scanning in console)
  • After arrival it remained stationary at the target Y coordinates (i.e. didn't fall)
  • Exiting the TARDIS makes it fall.
  • Took off again to the same coordinates in the air (i.e. in the same still loaded chunk)
  • TARDIS still didn't fall, except when exited

@DrTheodor
Copy link
Member Author

yeah thats tragic im not sure why that happening and how to fix it except for using safe pos search

@Mansarde
Copy link
Collaborator

Mansarde commented May 2, 2025

yeah thats tragic im not sure why that happening and how to fix it except for using safe pos search

Is safe pos search what happens if the TARDIS has land types enabled, to look for a suitable position on the ground?

@DrTheodor
Copy link
Member Author

yes

@DrTheodor DrTheodor added the S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loqor Loqor Awaiting requested review from Loqor

@MaketendoDev MaketendoDev Awaiting requested review from MaketendoDev

@duzos duzos Awaiting requested review from duzos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. A: Core Tech Area: Underlying core tech for the mod and the Github repository. A: Engine Area: Tardis engine. A: Tardis Components Area: Tardis components & manager. S: DO NOT MERGE Status: Open item that should NOT be merged. DNM. Allows test to run unlike draft. S: Help Wanted Status: Requesting additional help for this to be completed. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. S: Needs Review Status: Requires additional reviews before being fully accepted. S: Needs Testing Status: Requires testing. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Milestone
1.2.0 PATCHES
Development

Successfully merging this pull request may close these issues.
3 participants
@DrTheodor @Mansarde @duzos