feat: Update getLog().download() to support returning logs to caller #933
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update options to support a new property "returnLogsToCaller" to obtain logs at callsite rather than downloading logs to disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update options for getLog().download() to support a new property returnLogsToCaller to obtain logs at callsite rather than downloading logs to disk.
Description of changes:
Hello connect team !
As of today, while debugging issues upon agent reports, they are required to download logs to disk first and then use a messaging platform like email/slack to send the agent log file. This has proven to be cumbersome and we are left with a massive trail of attachments sometimes on our issue tracking systems. I am opening this PR in hopes to access the logs directly from the callsite, with the plan being to refer the logs object and stream it back to an issue reporting service if you will. We want to use this as a means to build an automated issue reporting feature into our application and this would be helpful.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.