Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gemfile order issue #108

Closed
wants to merge 2 commits into from
Closed

Fix Gemfile order issue #108

wants to merge 2 commits into from

Conversation

jclusso
Copy link
Contributor

@jclusso jclusso commented Feb 25, 2024

Fixes: #107

@jclusso jclusso marked this pull request as draft February 25, 2024 20:49
@jclusso
Copy link
Contributor Author

jclusso commented Feb 25, 2024

I just determined this currently causes problems in Rails applications that don't use Active Record. Looking into a fix.

@jclusso
Copy link
Contributor Author

jclusso commented Feb 25, 2024

The fix was not requiring if it's aleady defined.

@jclusso jclusso marked this pull request as ready for review February 25, 2024 21:08
HarlemSquirrel
HarlemSquirrel reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! I'm going to try this out along with autoload when I have some free time but it may take me a few days. Sorry for the delay

lib/amazing_print.rb Show resolved Hide resolved
@jclusso jclusso closed this Mar 8, 2024
@jclusso jclusso deleted the fix_gemfile_order_issue branch March 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel left review comments

@paddor paddor Awaiting requested review from paddor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gemfile order matters
2 participants
@jclusso @HarlemSquirrel