Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mongoid field aliases #106

Merged

Conversation

jclusso
Copy link
Contributor

@jclusso jclusso commented Jan 12, 2024

This makes it so the field name is printed with the alias in parentheses instead of the alias being printed as the field name.

This makes it so the field name is printed with the alias in parentheses instead of the alias being printed as the field name.
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Do you have a moment to write a test and amend the changelog?

@jclusso
Copy link
Contributor Author

jclusso commented Feb 9, 2024

@HarlemSquirrel I'm not 100% sure how appraisals work with the CI and what not but I had to add newer versions to even get the tests to run for me.

Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HarlemSquirrel HarlemSquirrel added this pull request to the merge queue Feb 12, 2024
Merged via the queue into amazing-print:master with commit 0b860b7 Feb 12, 2024
9 of 10 checks passed
@jclusso jclusso deleted the add_mongoid_field_aliases branch February 12, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants