Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ambassador API parsing more resilient to bad data #252

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Make ambassador API parsing more resilient to bad data #252

merged 2 commits into from
Mar 10, 2025

Conversation

MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Mar 8, 2025

  • Install version 0.54.0 of the data package, which lacks the new species/enclosure types from Add plant ambassadors data#127
  • Observe new ambassadors still show in extension
  • git reset --hard HEAD~1 locally to remove the generic types fix
  • Observe new ambassadors logged as parse failures
  • Observe API ambassador data/images still used for remaining ambassadors

@MattIPv4 MattIPv4 mentioned this pull request Mar 8, 2025
Merged
@MattIPv4 MattIPv4 marked this pull request as ready for review March 8, 2025 19:05
@MattIPv4 MattIPv4 requested a review from pjeweb March 8, 2025 19:05
@MattIPv4 MattIPv4 merged commit 64bb6ab into main Mar 10, 2025
6 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/improve-ambassador-parsing branch March 10, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjeweb pjeweb pjeweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattIPv4 @pjeweb