Chatbot API #37
Chatbot API #37
Conversation
src/connections/api.js
Outdated
| // Global error handling | ||
| process.on('unhandledRejection', (reason, promise) => { | ||
| console.error('Unhandled Rejection at:', promise, 'reason:', reason); | ||
| }); | ||
|
|
||
| process.on('uncaughtException', (error) => { | ||
| console.error('Uncaught Exception:', error); | ||
| }); |
There was a problem hiding this comment.
Not a fan of adding global stuff into a specific connection file -- this will stop any fatal error across the entire bot from killing the process
There was a problem hiding this comment.
This was same as below, to avoid having the API crash the node, but you are correct not good practice to have global stuff in the connection file, will remove.
src/connections/api.js
Outdated
| } catch (error) { | ||
| console.error('Failed to instantiate API:', error.message); | ||
| } |
There was a problem hiding this comment.
Similarly here, not sure this should have a try/catch -- if it fails, it should fail
There was a problem hiding this comment.
I think my goal was to make sure nothing with the API takes down the entire chatbot as the API is not critical to the bots functioning. But if its better practice to remove the try/catch we can do that.
src/connections/cameras.js
Outdated
| async #getBinary(endpoint) { | ||
| try { | ||
| const url = `http://${this.#host}${endpoint}`; | ||
| console.log(`Fetching binary data from: ${url}`); // Log the request URL |
src/connections/cameras.js
Outdated
|
|
||
| // Return the response as an ArrayBuffer | ||
| const data = await response.arrayBuffer(); | ||
| console.log('Received ArrayBuffer of size:', data.byteLength); // Log the size of the ArrayBuffer |
src/connections/cameras.js
Outdated
| } | ||
| } catch (error) { | ||
| this.#logger.error(`Failed to fetch image: ${error.message}`); // Improved error logging | ||
| console.error('Error fetching image:', error); |
There was a problem hiding this comment.
Yes should be logger, will change.
src/connections/api.js
Outdated
| if (this.controller) { | ||
| this.controller.ws = this.#ws; // Ensure controller.ws is set | ||
| this.#logger.log('controller.ws assigned'); | ||
| } |
There was a problem hiding this comment.
Why are we exposing what is intentionally marked as private in this class? There is already a standard pattern in place for other logic accessing connections from the controller, this violates that pattern?
There was a problem hiding this comment.
This was for sendAPI and sendBroadcast, but you make a good point, i will move both into the API class.
Add API to the chatbot
Add api command and camera function to fetch screenshots from the cameras.