Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new types in type_values of stocks.get_stock_dividends #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfilipe
Copy link

@mfilipe mfilipe commented Jun 19, 2022

This fix add new types in type_values which are being returned when search for dividends of Brazilian stocks.

Example (https://www.investing.com/equities/vale-on-n1-dividends):

<tr event_timestamp="1614902400">
<td class="left first" data-value="1614902400">Mar 05, 2021</td>
<td>0.8357368</td>
<td data-value="6" class="textNum left">
<span class="iconOther" title="Other"></span>
</td>
<td data-value="1615766400">Mar 15, 2021</td>
<td>6.75%</td>
</tr>
<tr event_timestamp="1614902400">
<td class="left first" data-value="1614902400">Mar 05, 2021</td>
<td>3.4259103</td>
<td data-value="7" class="textNum left">
<span class="iconInterim" title="Interim"></span>
</td>
<td data-value="1615766400">Mar 15, 2021</td>
<td>6.75%</td>
</tr>

IMO, those type_values shouldn't be linked to a dictionary, the values must be a lowercase of span.title. This will avoid problems in the future when Investing.com defines new unexpected types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant