Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build as shared + Migrate testing to Python #73

Merged
merged 44 commits into from
Jan 10, 2021
Merged

Conversation

alrevuelta
Copy link
Owner

@alrevuelta alrevuelta commented Sep 11, 2020

Fix #60

  • Migrates all testing of operators and models to Python, by building a shared library and interfacing to it from Python.
  • Migrates the benchmarking of models to Python. Now there is no need to use files.
  • Simplify the Makefile.
  • Proof of concept before using new test data (organised by opset version and domain in Crawl previous onnx tests #67)

Migrate benchmarking to Python. No more using files to read the inference time.
Fix print
Fix test_operators.py and update docs
Fix encoding
Minor fix
Fix tracing
Add fpic for shared library
@nopeslide
Copy link
Collaborator

Nice start

static library

shouldn't this be dynamic/shared in the PR text?

@alrevuelta
Copy link
Owner Author

shouldn't this be dynamic/shared in the PR text?

You are absolutely right.

I'm gonna need a bit of help with the Makefile, might be doing really nasty stuff. Can you have a look? The main problem now is that we need to compile with the -fpic flag all the code, but we only want this for the shared library. Should be have a target like compile_shared or something like that?

Add -fpic and fix benchmarking
Debug Win CI fail
More traces for Win CI issue
More traces for win ci issue
debug win
minor refactoring
fix win ci
fix win ci
f*** windows ci
Migrate benchmarking to Python. No more using files to read the inference time.
Fix print
Fix test_operators.py and update docs
Fix encoding
Minor fix
Fix tracing
Add fpic for shared library
Add -fpic and fix benchmarking
Debug Win CI fail
More traces for Win CI issue
More traces for win ci issue
debug win
minor refactoring
fix win ci
fix win ci
f*** windows ci
@alrevuelta alrevuelta force-pushed the migrate-python-tests branch from 52a540f to c3c5e43 Compare January 8, 2021 14:41
@alrevuelta alrevuelta changed the title Migrate operators/models test to Python Build as shared + Migrate testing to Python Jan 8, 2021
@alrevuelta alrevuelta force-pushed the migrate-python-tests branch from 7772fc0 to d6587b9 Compare January 8, 2021 15:39
@alrevuelta alrevuelta marked this pull request as ready for review January 8, 2021 16:08
@alrevuelta alrevuelta merged commit 824d494 into master Jan 10, 2021
@alrevuelta alrevuelta deleted the migrate-python-tests branch January 10, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build connxr as a shared library, to enable python bindings for testing
2 participants