fixup! fix: Database Migration does set current version in DB Friends…

…OfSymfony1#98
alquerci · Jul 3, 2024 · 5897f6d · 5897f6d
1 parent 88cfed5
commit 5897f6d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 36 deletions.
diff --git a/tests/MigrationTestCase.php b/tests/MigrationTestCase.php
@@ -32,13 +32,13 @@
  */
 class Doctrine_Migration_TestCase extends Doctrine_UnitTestCase
 {
-    const TABLES = array(
-        'MigrationPhonenumber',
-        'MigrationUser',
-        'MigrationProfile',
-    );
-
-    protected $tables = self::TABLES;
+    public function prepareTables()
+    {
+        $this->tables[] = 'MigrationPhonenumber';
+        $this->tables[] = 'MigrationUser';
+        $this->tables[] = 'MigrationProfile';
+        parent::prepareTables();
+    }
 
     public function testMigration()
     {
@@ -127,33 +127,4 @@ public function testMigrationClassNameInflected()
             $this->assertTrue($code);
         }
     }
-
-    public function test_afterSuccessfullMigration_willSetMigratedVersionAsCurrentVersionInMysqlDB()
-    {
-        $connection = $this->openMysqlAdditionalConnection();
-        $this->resetTablesOnConnection(self::TABLES, $connection);
-
-        $migration = new Doctrine_Migration('migration_classes', $connection);
-        $migration->setCurrentVersion(3);
-
-        $migration->migrate(4);
-        $this->assertEqual(4, $migration->getCurrentVersion());
-    }
-
-    public function test_afterFailedMigration_willKeepCurrentVersionInMysqlDB()
-    {
-        $connection = $this->openMysqlAdditionalConnection();
-        $this->resetTablesOnConnection(self::TABLES, $connection);
-
-        $migration = new Doctrine_Migration('migration_classes', $connection);
-        $migration->setCurrentVersion(0);
-
-        try {
-            $migration->migrate(1);
-
-            $this->fail('migration must fail');
-        } catch (Doctrine_Migration_Exception $e) {
-            $this->assertEqual(0, $migration->getCurrentVersion());
-        }
-    }
 }
diff --git a/tests/run.php b/tests/run.php
@@ -279,6 +279,7 @@
 // Migration Tests
 $migration = new GroupTest('Migration Tests', 'migration');
 $migration->addTestCase(new Doctrine_Migration_TestCase());
+$migration->addTestCase(new Doctrine_Migration_Mysql_TestCase());
 $migration->addTestCase(new Doctrine_Migration_Base_TestCase());
 $migration->addTestCase(new Doctrine_Migration_Diff_TestCase());
 $test->addTestCase($migration);