Issue #761 : Namespace Arethusa CSS

[PonteIneptique]

Fix for #761 : I chose the class .__artsa to minimize collision. Now, if arethusa is installed somewhere else, we need to remember to add this class :) If I should add this in some doc, please tell me.

[coveralls]

Coverage remained the same at 43.174% when pulling 40aa835 on issue-761 into 1cd0320 on master.

[balmas]

@fbaumgardt can you review? Thanks!

[fbaumgardt]

@PonteIneptique @balmas Sorry for the slow response, first I had issues with a clean build, because of out-of-sync dependencies; then I tried to figure out whether the CSS issues I am seeing are due to anything in my setup. If that's the case I have not found the offender yet. Have you tried running this from a fresh build, any issues?

I get this screen upon pageload and when I resize it behaves erratically, i.e. the arethusa canvas resizes beyond the edge of the viewport.

[PonteIneptique]

Hmm. Probably means the namespacing I added should have been applied on the whole document. Could you try adding the namespace class to the html document (if it is even possible to do so...)

[balmas]

I think the namespacing might also need a little refinement --- when I did it I noticed some things getting namespaced in a way wasn't quite right, e.g.

.arethusa html
.arethusa body

[fbaumgardt]

That helped with some of the missing style attributes but the canvas size issue remains.

Am 17.06.2016 um 10:09 schrieb Thibault Clérice [email protected]:

Hmm. Probably means the namespacing I added should have been applied on the whole document. Could you try adding the namespace class to the html document (if it is even possible to do so...)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #762 (comment), or mute the thread https://github.com/notifications/unsubscribe/AAhw3-C8vF__OMh10RDchC_ZbxRuoZxCks5qMqqUgaJpZM4Iwxuh.