Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version constraints failures. #345

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Fix version constraints failures. #345

merged 1 commit into from
Mar 13, 2021

Conversation

Maikuolan
Copy link
Member

#324 and #325 currently suffer from tests failures, which seem to originate due to the PHP version constraints specified by composer.json. This PR should, hopefully, fix those failures (when, of course, they're eventually ready to be merged later).

(Changes to composer.lock are a result of php composer.phar update performed after updating composer.json).

@Maikuolan Maikuolan requested a review from lablnet March 13, 2021 09:10
Copy link
Member

@lablnet lablnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@lablnet lablnet merged commit 60e8b2f into alphazframework:master Mar 13, 2021
@Maikuolan
Copy link
Member Author

The only failure remaining here now, seems to be because of Scrutinizer. But, I don't think that's our fault, because Zest isn't even mentioned anywhere at all in the stack trace:

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399
PHP Stack trace:
PHP   1. {main}() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Autoload::load($class = 'PHP_CodeSniffer\\Config') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Runner.php:67
PHP   4. PHP_CodeSniffer\Autoload::loadFile($path = '/home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/autoload.php:134
PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399
PHP Stack trace:
PHP   1. {main}() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Autoload::load($class = 'PHP_CodeSniffer\\Config') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Runner.php:67
PHP   4. PHP_CodeSniffer\Autoload::loadFile($path = '/home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/autoload.php:134
Setting configuration file : /home/scrutinizer/tmp/scrutinizer_toolconfigs/phpcs.xml
PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399
PHP Stack trace:
PHP   1. {main}() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Autoload::load($class = 'PHP_CodeSniffer\\Config') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Runner.php:67
PHP   4. PHP_CodeSniffer\Autoload::loadFile($path = '/home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/autoload.php:134

I guess, somebody made a typo somewhere in PHP_CodeSniffer, maybe..? "ಠ_ಠ

(Eh.. Oh well.. At least, we've done everything that we can, I think).

@Maikuolan Maikuolan deleted the patch-1 branch March 13, 2021 09:25
@lablnet
Copy link
Member

lablnet commented Mar 13, 2021

The only failure remaining here now, seems to be because of Scrutinizer. But, I don't think that's our fault, because Zest isn't even mentioned anywhere at all in the stack trace:

PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399
PHP Stack trace:
PHP   1. {main}() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Autoload::load($class = 'PHP_CodeSniffer\\Config') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Runner.php:67
PHP   4. PHP_CodeSniffer\Autoload::loadFile($path = '/home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/autoload.php:134
PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399
PHP Stack trace:
PHP   1. {main}() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Autoload::load($class = 'PHP_CodeSniffer\\Config') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Runner.php:67
PHP   4. PHP_CodeSniffer\Autoload::loadFile($path = '/home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/autoload.php:134
Setting configuration file : /home/scrutinizer/tmp/scrutinizer_toolconfigs/phpcs.xml
PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php on line 399
PHP Stack trace:
PHP   1. {main}() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:0
PHP   2. PHP_CodeSniffer\Runner->runPHPCS() /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/bin/phpcs:18
PHP   3. PHP_CodeSniffer\Autoload::load($class = 'PHP_CodeSniffer\\Config') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Runner.php:67
PHP   4. PHP_CodeSniffer\Autoload::loadFile($path = '/home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/src/Config.php') /home/scrutinizer/.analysis/phpcs/vendor/squizlabs/php_codesniffer/autoload.php:134

I guess, somebody made a typo somewhere in PHP_CodeSniffer, maybe..? "ಠ_ಠ

(Eh.. Oh well.. At least, we've done everything that we can, I think).

yeah agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants