Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native and other dependencies. Add rotation support to image view. #79

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

pappnu
Copy link

@pappnu pappnu commented Aug 29, 2021

Updates React Native and a bunch of other dependencies, but I didn't touch the ios files at all, since I don't have a compatible dev environment, so this probably breaks ios builds. Also adds rotation support to image view. I enabled Hermes and ProGuard for Android so disable those if they aren't desired.

If there's something you want changed let me know.

Dependencies

Most of the updates didn't require any changes to the code. React Navigation and pager view required some changes. Especially this breaking change is hard for me to check for and at least search filtering required the old behaviour. The most important changes are outlined below.

  • @react-native-community/async-storage replaced with @react-native-async-storage/async-storage
  • @react-native-community/viewpager replaced with react-native-pager-view
  • react-navigation updated to version 6.x.x
  • @react-navigation/stack replaced with @react-navigation/native-stack although the components that use this don't seem to be in use anymore
  • react-native 0.63.3 -> 0.69.x
  • react-native-tab-view-viewpager-adapter: removed since tab-view 3.x already uses pager view
  • rn-fetch-blob replaced with react-native-blob-util
  • react-native-orientation-locker added for rotation support

To see all the changes you can use e.g. git diff react-native-update master -- package.json.

Testing

I have only browsed around and tried the search functionality for testing. I also made sure that saving images and datetime picking still works. There is still high probability that something is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant