-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React Native and other dependencies. Add rotation support to image view. #79
Open
pappnu
wants to merge
46
commits into
alphasp:master
Choose a base branch
from
pappnu:react-native-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 516b1f9. React Native Reanimated 2.3.0-alpha.2 caused an error on app reloads.
React Navigation 6 doesn't merge navigation params by default anymore, which broke filtering.
lodash, y18n, hosted-git-info, ua-parser-js, path-parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates React Native and a bunch of other dependencies, but I didn't touch the ios files at all, since I don't have a compatible dev environment, so this probably breaks ios builds. Also adds rotation support to image view. I enabled Hermes and ProGuard for Android so disable those if they aren't desired.
If there's something you want changed let me know.
Dependencies
Most of the updates didn't require any changes to the code. React Navigation and pager view required some changes. Especially this breaking change is hard for me to check for and at least search filtering required the old behaviour. The most important changes are outlined below.
To see all the changes you can use e.g.
git diff react-native-update master -- package.json
.Testing
I have only browsed around and tried the search functionality for testing. I also made sure that saving images and datetime picking still works. There is still high probability that something is broken.